Skip to content

xdsclient: fix the flaky ADS stream restart test #8631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

xdsclient: fix the flaky ADS stream restart test #8631

wants to merge 1 commit into from
+61 −115

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Oct 6, 2025

The ADS stream restart test can be flaky for the following reason:

  • It requests a CDS resource and unrequests it before the stream breaks.
  • And then once the stream restarts, it verifies that this resource is not requested again.
  • But the ACK for this resource may or may not be received at the management server before the stream breaks. This can falsely cause the test to conclude that the request was re-requested after the restart.

This PR changes the test in the following ways:

  • Use a single resource
  • Verify ACK before the stream is restarted

Ran a million times without flakes on Forge.

RELEASE NOTES: NONE

@easwars easwars requested a review from arjan-bal October 6, 2025 17:05
@easwars easwars added Type: Testing Area: xDS Includes everything xDS related, including LB policies used with xDS. labels Oct 6, 2025
@easwars easwars added this to the 1.77 Release milestone Oct 6, 2025
@codecov Codecov
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.00%. Comparing base (8389ddb) to head (15a0818).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8631      +/-   ##
==========================================
- Coverage   82.13%   82.00%   -0.13%     
==========================================
  Files         415      415              
  Lines       40711    40711              
==========================================
- Hits        33437    33385      -52     
- Misses       5897     5941      +44     
- Partials     1377     1385       +8

see 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjan-bal arjan-bal Awaiting requested review from arjan-bal

At least 1 approving review is required to merge this pull request.

Assignees

@arjan-bal arjan-bal

Labels
Area: xDS Includes everything xDS related, including LB policies used with xDS. Type: Testing
Projects
None yet
Milestone
1.77 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@easwars @arjan-bal